search

VEuPathDB / web-eda

Web browser code for EDA-based applications
Apache License 2.0
0 stars 0 forks source link

hiding map-related Viz icons under FSM #1672

Closed moontrip closed 1 year ago

moontrip commented 1 year ago

This will resolve https://github.com/VEuPathDB/web-eda/issues/1664. What is done is to add a prop to let the child component (NewVisualizationPicker) know whether the parent component is FSM or not. If it is from FSM, then map-related Viz icons is hidden in the Select Visualization.

Here is a screenshot under FSM, which two map-related Viz icons such as map-markers and map-markers-overlay are not shown. Certainly, in a normal mode, the New Visualization shows all Viz icons.

fsm-geomap-icons

moontrip commented 1 year ago

@bobular Thank you for your information. I didn't know the ticket you mentioned. Yes if this is not urgent, then we can wait for the backend change. I will close this PR as won't fix.