VEuPathDB / web-eda

Web browser code for EDA-based applications
Apache License 2.0
0 stars 0 forks source link

Add warning banner for download table preview for entities with lots of vars #1673

Closed asizemore closed 1 year ago

asizemore commented 1 year ago

Resolves #1652

Current behavior

Screen Shot 2023-03-03 at 10 58 13 AM

Now it looks like:

Screen Shot 2023-03-03 at 10 58 38 AM

That error banner only comes up once i've clicked at least one var.

Is it weird to have both banners? I thought about removing the server-error banner, but i dont want to hide errors that might be useful to us to see later...

dmfalke commented 1 year ago

I think we want to avoid making the request if showPreviewTableWarning === true.

I would rename that variable to something like canLoadTablePreview and define it closer to the top of the component, and use that value as a part of this condition.

dmfalke commented 1 year ago

I would rename that variable to something like canLoadTablePreview and define it closer to the top of the component, and use that value as a part of this condition.

Hmm... maybe this would be a better place to add the check.

asizemore commented 1 year ago

Thanks @dmfalke ! Now after the update it looks like:

Screen Shot 2023-03-06 at 2 01 55 PM