search

VEuPathDB / web-eda

Web browser code for EDA-based applications
Apache License 2.0
0 stars 0 forks source link

Make line plot 0/0 proportions have hollow circle #1686

Open chowington opened 1 year ago

chowington commented 1 year ago

Fixes https://github.com/VEuPathDB/web-eda/issues/1082

bobular commented 1 year ago

Had a quick look at the "splitting" code. Was wondering why the nullZeroHack function is still used. But as I say, it was a very quick look. Are you ready for a more detailed look at the new code?

chowington commented 1 year ago

Had a quick look at the "splitting" code. Was wondering why the nullZeroHack function is still used. But as I say, it was a very quick look. Are you ready for a more detailed look at the new code?

I plan on removing my added code in nullZeroHack that handles the marker.symbol array, but the original version of the function should stay, right?

A detailed look might be helpful if you have any ideas on how to fix the nasty TS errors that I've been sidestepping with these anys! I spent time trying to handle it more robustly, but it's a bit of a monster, at least to me.

Also, there's the one property facetVariableDetails that's giving me a headache because it's a constant-size tuple (a TS concept, whereas it's just another array in JS), meaning it shouldn't be iterated over as an array, but TS/JS doesn't seem to give any method for weeding out tuples from general arrays. So I'm just excluding it manually, which is annoying. Any thoughts?

bobular commented 1 year ago

I plan on removing my added code in nullZeroHack that handles the marker.symbol array, but the original version of the function should stay, right?

The nullZeroHack was originally designed to handle the 0/0 cases because their y values were null (though sadly my code comments don't say that in as many words). We can remove it if we're creating a new zeroOverZero series.