search

VEuPathDB / web-eda

Web browser code for EDA-based applications
Apache License 2.0
0 stars 0 forks source link

Bug: 500 error when plot mode other than RAW is selected for scatterplot with continuous overlay #1697

Closed danicahelb closed 1 year ago

danicahelb commented 1 year ago

Using WASHb BNG:

Same thing happens when plot modes "Smoothed mean" or "Best fit" are selected while using a continuous overlay

image
danicahelb commented 1 year ago

When incompatible selections are made (for ex: plot mode: smooth mean & log scale) we do not draw points on the plot and we show a yellow warning content message

image

We want the same behavior here. Users can select incompatible options, but if they do they will not see points on the plot area and they will see a content message.

Smooth mean and Best fit are incompatible options with continuous overlay variables. Yellow content message should read:

Plot modes with fitted lines are not available when continuous overlay variables are selected. Why?

and

Plot modes with fitted lines are not available when continuous overlay variables are selected. Continuous overlay variable values are not binned. Read less

@d-callan do you have any comments on the verbiage? Especially the more detailed one?

aaronwlsong commented 1 year ago

Looks good now, closing ticket.

Image

moontrip commented 1 year ago

@aaronwlsong Thanks again for your reviews 😄 👍