Backend date parser does not expect trailing 'Z'

VEuPathDB / web-eda

Web browser code for EDA-based applications

Apache License 2.0

0 stars 0 forks source link

Backend date parser does not expect trailing 'Z' #605

Open ryanrdoherty opened 3 years ago

ryanrdoherty commented 3 years ago

In at least two places in the subsetting service (date filters, date distribution ranges), the client is sending date values with format 'yyyy-MM-ddThh:mm:ssZ' (with a trailing 'Z'). The subsetting service was recently "cleaned up" to only support ISO format without a trailing Z (i.e. ISO_LOCAL_DATE_TIME). Would like the Z omitted. This issue is linked to and must precede merging of https://github.com/VEuPathDB/EdaSubsettingService/pull/45.

ryanrdoherty commented 1 year ago

@dmfalke Is this done? Looks like backend code was merged in October, so client must be doing the right thing with dates now, right?

dmfalke commented 1 year ago

@ryanrdoherty I checked, and the client is still sending dates with the trailing "Z".

This is an example payload sent to the distribution endpoint:

{
    "binSpec": {
        "binUnits": "month",
        "binWidth": 1,
        "displayRangeMax": "2011-01-31T00:00:00Z",
        "displayRangeMin": "2003-01-22T00:00:00Z"
    },
    "filters": [],
    "valueSpec": "count"
}

The service doesn't reject this request. Do you know how this might impact the response?