VEuPathDB / web-eda

Web browser code for EDA-based applications
Apache License 2.0
0 stars 0 forks source link

Study details stand alone page and/or tab for "Prerelease" and "Private" studies #809

Closed SheenaTomko closed 2 years ago

SheenaTomko commented 2 years ago

Jay loaded the study characteristics and everything from the ClinEpiPresenter that's needed for the all studies table and study details page for the "Prerelease" studies: India ICEMR DAMaN Quasi-experimental Stepped-wedge, LAKANA Cluster Randomized Trial, Namibia rfMDA RAVC Cluster Randomized Trial, and PERCH Case Control.

We would like a user to be able to click on the name of this study and be re-directed to the study details tab for it. However, at the moment, the user first gets a pop-up like the one below, and if they click the link, they get a page with an error message.

Screen Shot 2022-01-18 at 2 41 38 PM

Error message:

Screen Shot 2022-01-18 at 2 41 45 PM

As a reminder, "Prerelease" studies are studies with data that we plan to load (and in some cases have already loaded), where we want the study card and study page to be publicly accessible before the data is released.

Proposal:

  1. Have all links for a "Prerelease" study re-direct to the "View study details" tab
  2. Grey out all other tabs (Browse and Subset, Visualize, etc.) and make them unclickable or remove them completely
  3. Remove the entity diagram
  4. Remove the "New Analysis", "My analyses", and "Make Analysis Public" links
  5. If someone is logged into a ClinEpi account that has access to the study, and there is real data loaded, they should be able to see the EDA appear as normal for that study (this can be done for a later release if needed)
bobular commented 2 years ago

DF: Simplest path could be a standalone study record page (instead of as first tab in EDA)

danicahelb commented 2 years ago

Discussed in 1/28/2022 EDA meeting:

Stand-alone study pages are needed for both prerelease and private studies. Currently, users cannot access the study page (the link in the popup currently takes you to “Page not found”; we need this link to take the user to a stand-alone study page)

- Note: studies that are pre-release on the live site are private on the QA site so that providers for various studies cannot access data from other studies before it is released

For private studies:

For prerelease studies where data is available on the live site:

For prerelease studies where data is NOT yet available on the live site:

dmfalke commented 2 years ago

Note: I did not add the banner to the page for private studies. We hadn't done this in the past, so I thought I would ask. It shouldn't be too hard to add.

nkittur-uga commented 2 years ago

So...this one is almost there. When I try to access a private/prerelease study, I get this error pop-up, however when I chose the error pop-up, the study page is there and looks great.

Screen Shot 2022-02-16 at 9 32 40 AM
dmfalke commented 2 years ago

Ah, strange. That wasn’t happening on my development site. I’ll take a look!

On Wed, Feb 16, 2022 at 9:34 AM nkittur-uga @.***> wrote:

So...this one is almost there. When I try to access a private/prerelease study, I get this error pop-up, however when I chose the error pop-up, the study page is there and looks great. [image: Screen Shot 2022-02-16 at 9 32 40 AM] https://user-images.githubusercontent.com/67710160/154286484-50f92384-76dd-4802-b251-44234c16c2f5.png

— Reply to this email directly, view it on GitHub https://github.com/VEuPathDB/web-eda/issues/809#issuecomment-1041555317, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACZEU7D3NWZYOENHLSZ5NTU3OYYVANCNFSM5MWNPZPA . You are receiving this because you modified the open/close state.Message ID: @.***>

dmfalke commented 2 years ago

I am not able to reproduce. In what browser is this happening?

nkittur-uga commented 2 years ago

Chrome.

nkittur-uga commented 2 years ago

All studies denoted "Private" need a button on the study page to request access to the data.

Clicking on this button will prompt users to log in, and if their accounts have been added as study team members, then they can access the data for QA. This feature isn’t essential for b56, but should be prioritized right after all essential functionality for b56 is done, because study teams will be looking at their private studies for QA.

dmfalke commented 2 years ago

Chrome.

I'm still unable to reproduce this. Is this happening consistently for you?

nkittur-uga commented 2 years ago

Yes, unfortunately still happening for all private and prerelease studies.

dmfalke commented 2 years ago

I'm going to need some more details about this error. Maybe we can chat on slack later.

dmfalke commented 2 years ago

All studies denoted "Private" need a button on the study page to request access to the data.

Clicking on this button will prompt users to log in, and if their accounts have been added as study team members, then they can access the data for QA. This feature isn’t essential for b56, but should be prioritized right after all essential functionality for b56 is done, because study teams will be looking at their private studies for QA.

Ah, yes, this makes sense. Since we are redirecting to the standalone page, the typical popup is not seen. I will work on this.

nkittur-uga commented 2 years ago
Screen Shot 2022-02-24 at 11 03 35 AM

Banner is seen as expected.