Map - either use `isVisible` prop or get rid of it

[moontrip]

Separated from https://github.com/VEuPathDB/web-monorepo/issues/935 as a tech debt

isVisible tech debt

At the moment, both visualizationPanelConfig and studyDetailsPanelConfig (in appState.ts) are of type PanelConfig which is

const PanelConfig = t.type({
  isVisible: t.boolean,
  position: PanelPositionConfig,
  dimensions: t.type({
    height: t.union([t.number, t.string]),
    width: t.union([t.number, t.string]),
  }),
});

The SubStudies (list of sub-studies) floater is conditionally rendered based on appState.studyDetailsPanelConfig?.isVisible but the DraggableVisualization (supporting plot) is rendered based on the truthiness of various variables, ultimately dependent on the truthiness of its activeVisualizationId prop.

There is currently logic setting/unsetting visualizationPanelConfig.isVisible but it is not used to conditionally render the panel.

We could either a) remove isVisible as a prop from visualizationPanelConfig and remove the logic setting/unsetting isVisible or b) standardise the behaviour and make DraggableVisualization conditional rendering make use of visualizationPanelConfig.isVisible

Given that the showControls work could involve changing the props of visualizationPanelConfig - maybe a) is the better option?

• Update: Due to recent change by https://github.com/VEuPathDB/web-monorepo/pull/967, currently duplicated conditional renderings of the floating viz panel were set. Is it necessary to add this conditional rendering if we're not changing the conditional rendering within DraggableVisualization? Removing the conditional rendering within DraggableVisualization?

Bob said he preferred to have outer conditional rendering so this ticket will be set to remove internal conditional rendering. Note that my initial attempt revealed that there existed many type issues if removing internal condition.

[dmfalke]

My 2 cents: I think we should keep the isVisible property and get rid of activeVisualizationId. There have been discussions about allowing multiple floating visualizations, and this will put us in a better position to deliver that.