Clinepi MAP: using a filter with same variable as the marker variable is prone to errors

VEuPathDB / web-monorepo

A monorepo that contains all frontend code for VEuPathDB websites

Apache License 2.0

2 stars 0 forks source link

Clinepi MAP: using a filter with same variable as the marker variable is prone to errors #1138

Open aurreco-uga opened 4 months ago

aurreco-uga commented 4 months ago

cannot reproduce the error in vectorbase map

try: https://clinepidb.org/ce/app/workspace/analyses/6QUfqKm/import that is the error.

To reproduce.

remove filters, it all works. the marker variable is Village.
add a village filter with 1 value: eg: "Chhnaeng": marker panel shows only "Chhnaeng"
add another value, eg "Sraeampilleu": marker panel does NOT add "Sraeampilleu" (BUG)
now remove value "Chhnaeng" in filter: marker empty, we hit the 400

dmfalke commented 4 months ago

I believe this is related to how we handle when the subset changes. Selected marker config values are removed when they are not included in the subset filter. It may be related to filter sensitivity.

I think we should keep values not included in the subset filter. Without further investigation, I'm not sure how hard this will be. I plan to look at it in more detail soon.

dmfalke commented 4 months ago

This could also be due to the study having sparse geographic data.