VEuPathDB / web-monorepo

A monorepo that contains all frontend code for VEuPathDB websites
Apache License 2.0
2 stars 0 forks source link

Improve NoDataError handling #1174

Closed bobular closed 3 months ago

bobular commented 3 months ago

Fixes #1173

Before this fix, we were successfully intercepting Could not generate continuous variable metadata from the error thrown by the 500 response, so isNoDataError(error) was returning true. However the MapFloatingErrorDiv banner was displaying the raw error (see screenshots in issue).

Since we know it's a "no data error" it's OK to display a more user-friendly message (the same one we use when receiving a formal NoDataError that comes from the 204/null body response). So now it says The visualization cannot be made because no data remains after filtering.

image