Take a less agressive path when requesting user datasets from within eda

VEuPathDB / web-monorepo

A monorepo that contains all frontend code for VEuPathDB websites

Apache License 2.0

2 stars 0 forks source link

Closed dmfalke closed 2 months ago

dmfalke commented 3 months ago

This PR removes a code path that causes an error to be thrown, in favor of a conditional statement, for requesting user datasets within eda.

Resolves this error

ERROR
In order to use this feature, a VdiCompatibleWdkService must be configured.

dmfalke commented 3 months ago

LGTM. I'm not familiar with the bug this resolves but we're definitely not throwing an exception any more from assertIsVdiCompatibleWdkService

This addresses a bug you reported when running the start command for @veupathdb/eda :smile:

bobular commented 3 months ago

This addresses a bug you reported when running the start command for @veupathdb/eda 😄

Guess I'd better test that then!

bobular commented 3 months ago

libs/eda dev server works for me but see https://github.com/VEuPathDB/web-monorepo/pull/1195 (I needed this too)

dmfalke commented 2 months ago

libs/eda dev server works for me but see #1195 (I needed this too)

ok, will look!