search

VEuPathDB / web-monorepo

A monorepo that contains all frontend code for VEuPathDB websites
Apache License 2.0
2 stars 0 forks source link

Ortho 7 - table text search is flaky #1260

Open bobular opened 2 weeks ago

bobular commented 2 weeks ago

Depending on the size of the group and the speed of your typing, the behaviour can be very flaky (missed characters, or characters appear to be typed and then get undone soon after). I'm having the most problems with OG7_0000779, but it's likely dependent on the speed of your computer also.

The RealTimeSearchBox in RecordFilter is likely the cause. It has some issues. We should consider removing the debouncing and using useDeferredValue. This will require refactoring the component to a functional component...

bobular commented 5 days ago

This is fixed, isn't it? @dmfalke

dmfalke commented 5 days ago

This is fixed, isn't it? @dmfalke

I think so. I will test when the databases are back online.

dmfalke commented 5 days ago

I'm getting consistent results, but it's still laggy. The table can end up updating multiple times, if you aren't typing quickly. Each update can be pretty slow (several seconds), especially for larger groups. I need to spend more time profiling this to see where the time is being spent.

Something we can do in the immediate term is increase the delay for the search box (just in this instance).