VEuPathDB / web-monorepo

A monorepo that contains all frontend code for VEuPathDB websites
Apache License 2.0
2 stars 0 forks source link

Add citations to EDA download tab #14

Closed jernestmyers closed 1 year ago

jernestmyers commented 1 year ago

Closes https://github.com/VEuPathDB/web-eda/issues/1510 (note the "upgrade" option has been made into its own issue)

Here's a screenshot of the updated UI: image

jernestmyers commented 1 year ago

Right now the dataset citation is underneath the "Data Accessibility: {value}". That's not really the appropriate heading for the citation. Maybe "About this study" and then underneath that is data accessibility and the citation? Probably a question for the clinepi folks. I ask bc i would miss the dataset citation because i wouldn't be looking for it under the current heading. Probably even just changing to "Data Accessibility" and then the actual value could be underneath the heading, along wtih the citation, would be enough. What do you think?

I agree now that you point it out. @nkittur-uga , what are your thoughts?

nkittur-uga commented 1 year ago

Yes, @jernestmyers and @asizemore I agree that the heading does not look right.

Would it be easiest to make the text "Dataset citation" as large (font size) as "Dataset accessibility"?

jernestmyers commented 1 year ago

@asizemore Here's how @nkittur-uga 's request would look with a few tweaks:

Thoughts?

image

nkittur-uga commented 1 year ago

@jernestmyers We like how that looks!! Just one suggestion-

Could the existing "Please cite..." text be edited to below:

"Please cite that you accessed data via ClinEpiDB. The citation below can be used to reference the latest version of the data. Citations for previous data versions can be found under each release."

nkittur-uga commented 1 year ago

@jernestmyers One last comment- Danica wonders if we should remove the "Citation:" in front of the citation- is it redundant? I think it does the job of separating the actual citation from the text before it. Maybe removing "Citation:" and instead italicizing or bolding the citation would do the job. Please do as you see fit.

asizemore commented 1 year ago

Looks great! Thank you!! I agree that we can remove "Citation:" but i think we should either leave it styled as-is or italicize. The big heading draws enough attention to it that i don't think it needs bolding.

jernestmyers commented 1 year ago

Just pushed the "final" changes:

  1. Added the extra verbiage to the "Please cite" text
  2. Italicized the citation. This looked better to me than retaining the styling as-is
  3. Removed the ability to copy the citation by clicking the citation itself, thereby removing the custom tooltip logic (now we just leverage the tooltip built into the CoreUI buttons, for better or worse). Citation can only be copied via the button.

image

asizemore commented 1 year ago

Looks great! Thanks @jernestmyers !