Closed chowington closed 4 months ago
This is looking really great. I have some comments/questions:
Here is a screenshot of the table in Firefox:
@dmfalke, I implemented almost all of your suggestions. The only thing I couldn't figure out was keeping the side borders on the first column top cell. I played around a lot with the CSS, but couldn't get those borders to stay like the other first columns cells. Hopefully it doesn't stand out too much. What do you think?
Adding border-collapse: separate;
to the CSS rule for .MesaComponent .DataTable table
seems to do the trick. Maybe give that a shot?
@dmfalke Thanks for your work! I still see a couple of bugs: There's a pixel column of bleed-through on the left of the first header cell, and the last cell of the sticky column loses its borders when scrolling horizontally.
@dmfalke Thanks for your work! I still see a couple of bugs: There's a pixel column of bleed-through on the left of the first header cell, and the last cell of the sticky column loses its borders when scrolling horizontally.
Ah, good catch! Will try to fix it.
@chowington I just pushed another commit. Let me know how it looks to you.
@chowington I just pushed another commit. Let me know how it looks to you.
Looks good! I fixed yet another few issues. Final review? 🤞
Closes https://github.com/VEuPathDB/WDKClient/issues/191