search

VEuPathDB / web-monorepo

A monorepo that contains all frontend code for VEuPathDB websites
Apache License 2.0
2 stars 0 forks source link

Bipartite network api update #765

Closed d-callan closed 4 months ago

d-callan commented 4 months ago

resolves https://github.com/VEuPathDB/web-monorepo/issues/764

this will keep from breaking things that are currently working. idk if there were other changes you were anticipating..

d-callan commented 4 months ago

side note.. seems the bipartitenetwork viz is maybe more properly called a correlationbipartitenetwork ?? not urgent obviously, just a thought i had while looking at this

d-callan commented 4 months ago

I'd be curious to read through the other discussion. And I have questions about the stroke vs weight thing for the component, but I'll save them for Mon probably

d-callan commented 4 months ago

ok. so i changed some names to separate the viz and component types as requested. i think given how things are, its reasonable. though i do wonder if were potentially backing ourselves into a corner. are we very confident the component will never need to know about the underlying data? that will always be either the backend or the vizs job? given the way weve engineered things so far im ok w continuing w that assumption, just made me a bit nervous.

asizemore commented 4 months ago

Yes i think from a philosophical standpoint the component should not know about the data. It should be only drawing a network, exactly as given. It's everyone else's job to provide the context, and let the component be totally independent. There might be something that breaks that idea someday, but for now this setup seems like it should best handle all of our use cases.

dmfalke commented 4 months ago

I want to call that type BipartiteNetwork but that could be confusing with the component being named the same thing. @dmfalke might have an opinion here.

I'm not sure which type you want to call BipartiteNetwork. Regardless, my instinct is to say that we should not have a component named BipartiteNetwork, and instead should be something like BipartiteNetworkPlot. My thinking is that the component represents one way to "visualize" the network data. Does that make sense?

asizemore commented 4 months ago

@dmfalke sounds good. I added this renaming task to the bipartite network polishing gh issue.

dmfalke commented 4 months ago

Great. I wonder if there are other components that should have Plot appended to their name. Would you mind adding a note to check in the polish-up issue?