eda: analysis not found: suggest to the user, if the url was shared, to request a good import url from the owner

VEuPathDB / web-monorepo

A monorepo that contains all frontend code for VEuPathDB websites

Apache License 2.0

2 stars 0 forks source link

eda: analysis not found: suggest to the user, if the url was shared, to request a good import url from the owner #980

Open aurreco-uga opened 6 months ago

aurreco-uga commented 6 months ago

suggest user to request a good import url from owner (similar verbiage to what we do in strategies.) (users often share the wrong url).

in analyses, we dont need to get the import url from the owner.. we can just generate it by removing the study id and adding /import , or providing the short version: site/analysis/ID or site/map/ID (not sure we want to offer the import url to this user)

chowington commented 1 month ago

It looks like this might already be implemented, based on this code: https://github.com/VEuPathDB/web-monorepo/blob/356e52091b5c2609b8419b137d39b742c872d5ee/packages/libs/eda/src/lib/core/components/AnalysisError.tsx#L33-L54

@aurreco-uga Is it just not always showing up when it should? Are there different criteria for showing the share button text than just a 403 HTTP response?

dmfalke commented 1 month ago

I can confirm this is working (screenshot from prod site):

I wonder if this was fixed on qa, but not yet released when this issue was made.