search

VEuPathDB / web-study-data-access

Utilities and hooks for controlling end user access to study data
Apache License 2.0
0 stars 1 forks source link

Access Request Enhancements #25

Closed chowington closed 1 year ago

chowington commented 1 year ago

Works toward https://github.com/VEuPathDB/web-eda/issues/1150

Should be tested along with https://github.com/VEuPathDB/ClinEpiWebsite/pull/76

chowington commented 1 year ago

I'm opening this PR for review. It should be noted that most of the additions of priorAuth in the PR are just from me adding it to anywhere that had the other terms too. So I don't know whether all of those additions are necessary or desired, but I don't know the purposes of all of those code sections or where they are used. However adding all of them did fix the bug I was encountering. It would be great if someone with more knowledge of this part of the code would investigate more closely!

dmfalke commented 1 year ago

I'm opening this PR for review. It should be noted that most of the additions of priorAuth in the PR are just from me adding it to anywhere that had the other terms too. So I don't know whether all of those additions are necessary or desired, but I don't know the purposes of all of those code sections or where they are used. However adding all of them did fix the bug I was encountering. It would be great if someone with more knowledge of this part of the code would investigate more closely!

I'm not too familiar with this part of the code. What is an example of a priorAuth value?

chowington commented 1 year ago

A priorAuth value is basically a long-form string answer to the question, "Did you get approval from the study provider to download this data?" Does that answer your question, or were you asking something else?

dmfalke commented 1 year ago

A priorAuth value is basically a long-form string answer to the question, "Did you get approval from the study provider to download this data?" Does that answer your question, or were you asking something else?

Yes, that is helpful! If I understand this PR, that value is being added to a table(s) that end users see (the hooks are used in https://github.com/VEuPathDB/web-study-data-access/blob/main/src/study-access/components/StudyAccessController.tsx.

I haven't yet tested this PR, but it seems like we should get a screenshot of the result and ask the clinepi team if they want this addition, unless of course they asked for it. Does that sound reasonable to you?