search

VFCI / bcadata

Data Package to recreate the data from the paper by Angeletos, Collard, and Dellas, "Business Cycle Anatomy" (2020).
Other
0 stars 1 forks source link

Validate new data #9

Closed fernando-duarte closed 1 year ago

fernando-duarte commented 1 year ago

When new data is pulled, we should run some basic validation unit tests to make sure the new data looks correct. I am attaching a basic validation file that I created for the VFCI project that we can use as a starting point.

validate_data.R.zip

matdehaven commented 1 year ago

I'm going to go with a different package, testdat whose syntax is the same as the testthat package, which I've already used for other unit tests.

matdehaven commented 1 year ago

I have added some validation tests, which can be found at ./tests/testthat/test-pull_bcadata.R

fernando-duarte commented 1 year ago

Thanks, good tests, we can add more in the future if/when we run into data problems. One last request before closing this issue: could you make the ranges of allowable variables a bit wider? So e.g., interest rates -5 to 25 instead of -1 to 10?

matdehaven commented 1 year ago

Widened the acceptable values in the data validation.