search

VFPX / FoxUnit

Unit Testing in Visual FoxPro
25 stars 22 forks source link

AssertNotEqualsArrays generates failure message on successful assertion #17

Open mikepotjer opened 5 years ago

mikepotjer commented 5 years ago

This issue can be reproduced by running the FoxUnitTests.PRG unit test "testAssertNotEqualsArrays". As shown in the screenshot below, the assertion correctly returns true, and the test passes, but an Assertion Failure message is generated. The failure message can be confusing to someone who isn't aware of the bug, especially if the developer included a custom message in the assert.

image

eselje commented 5 years ago

Interesting...I'm looking to knock of some items in the backlog soon. Of course...feel free to fix it too! :)

Eric

On Wed, Jan 2, 2019 at 9:32 AM Mike Potjer notifications@github.com wrote:

This issue can be reproduced by running the FoxUnitTests.PRG unit test "testAssertNotEqualsArrays". As shown in the screenshot below, the assertion correctly returns true, and the test passes, but an Assertion Failure message is generated. The failure message can be confusing to someone who isn't aware of the bug, especially if the developer included a custom message in the assert.

[image: image] https://user-images.githubusercontent.com/9847353/50598110-c32e4f80-0e77-11e9-960e-7ee1e5abddc6.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/VFPX/FoxUnit/issues/17, or mute the thread https://github.com/notifications/unsubscribe-auth/AHy8TDOcUPJHF74isXDIZdHlnMfRu2Hzks5u_NEVgaJpZM4Zm0BJ .

mikepotjer commented 5 years ago

After some further testing, it appears that AssertNotEqualsArrays does not work at all. If I pass it 2 identical arrays (or pass the SAME array to both parameters), the assertion succeeds and does not display any failure messages.