VForWaTer / metacatalog

Modular metadata management platform for environmental data.
https://vforwater.github.io/metacatalog
GNU General Public License v3.0
3 stars 1 forks source link

added stringify option #105

Closed mmaelicke closed 3 years ago

mmaelicke commented 3 years ago

This is an approach to tackle #104

@MarcusStrobl can you check the changes and confirm if this now works for you? Before merging I need to add the stringify ooption to all other to_dict functions and consider renaming.

codecov[bot] commented 3 years ago

Codecov Report

Merging #105 into master will increase coverage by 0.04%. The diff coverage is 68.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
+ Coverage   56.91%   56.96%   +0.04%     
==========================================
  Files          54       54              
  Lines        2370     2375       +5     
==========================================
+ Hits         1349     1353       +4     
- Misses       1021     1022       +1     
Flag Coverage Δ
e2e 56.96% <68.42%> (+0.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
metacatalog/ext/io/reader.py 62.85% <60.00%> (+4.52%) :arrow_up:
metacatalog/util/dict_functions.py 39.53% <70.00%> (-0.47%) :arrow_down:
metacatalog/models/entry.py 68.03% <75.00%> (-0.02%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6d69cd4...693bf5e. Read the comment docs.