search

VForWaTer / metacatalog

Modular metadata management platform for environmental data.
https://vforwater.github.io/metacatalog
GNU General Public License v3.0
3 stars 1 forks source link

added tests to find a person #117

Closed AlexDo1 closed 3 years ago

AlexDo1 commented 3 years ago

Added tests to find a person person by uuid (check_get_by_uuid()) and created a new test to test the find_person() function.

It took me a while to figure out that the find_person() function directly returns a Person object when searching for a uuid and a list of Person objects when searching for other attributes like first_name. This makes sense, of course, since searching for attributes like names can have multiple results.

AlexDo1 commented 3 years ago

I would like to merge, but there is still a check in progress. Do you know what happens there?

image

mmaelicke commented 3 years ago

Never mind. It's the migration test that is failing. We still don't have the database migrated. I will do that soon

AlexDo1 commented 3 years ago

Okay, but I think that I still don´t have the authorization to merge this PR (which is okay with me).

mmaelicke commented 3 years ago

Now it should be possible. Can you try again?