search

VForWaTer / metacatalog

Modular metadata management platform for environmental data.
https://vforwater.github.io/metacatalog
GNU General Public License v3.0
3 stars 1 forks source link

unittest Fail #129

Closed mmaelicke closed 3 years ago

mmaelicke commented 3 years ago

@AlexDo1 currently, the unittest are failing because of this line:

https://github.com/VForWaTer/metacatalog/blob/8231b7e6989f4bc968341d7dd92bf7c5353fa932/metacatalog/ext/io/reader.py#L65

I think you forgot to rename this df here, because it is only crated 4 lines above in the other if branch. Maybe you meant the column_names or df_sql here?

AlexDo1 commented 3 years ago

I have been working on this recently and this is actually not my last commit, sorry. I just pushed a new commit on Github that should pass the unittest.

AlexDo1 commented 3 years ago

Just noticed that the unittest in github does not pass, locally on my PC the tests work. The error message in the test is: Error: : Operation not possible. No IO interface activated. Run metacatalog.ext.extension('io', InterfaceClass) to register

Do I have to run metacatalog.ext.extension('io', InterfaceClass) for the unittest to work in github?

mmaelicke commented 3 years ago

Yes. I quickly added the activation to the CI in https://github.com/VForWaTer/metacatalog/commit/c0b539b95bf1108209e0c939643f17c420a8edcd

If the tests in master pass, you can merge the changes into your branch and it should work.