AlexDo1 commented 2 years ago

The revision in this PR should update the unit "electrical conductivity" to "mS/cm".

AlexDo1 commented 2 years ago

I am not sure why the test https://github.com/VForWaTer/metacatalog/blob/e9634a950c6e760ff0803ff1ec65aa77df69eebd/metacatalog/test/test_api_install.py#L29 is failing. I thought changing units.csv additionally should solve the problem, since the data in metacatalog is compared to the .csv files in metacatalog/data/. On my local machine the tests are running fine..

Do you have any idea what´s going on here?

mmaelicke commented 2 years ago

I'll have to look into this in more detail...

codecov[bot] commented 2 years ago

Codecov Report

Merging #163 (ab330f5) into master (86ea28d) will decrease coverage by 0.01%. The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
- Coverage   63.59%   63.58%   -0.02%     
==========================================
  Files          66       67       +1     
  Lines        3085     3095      +10     
==========================================
+ Hits         1962     1968       +6     
- Misses       1123     1127       +4

Flag	Coverage Δ
e2e	`63.58% <60.00%> (-0.02%)`	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
metacatalog/db/revisions/__init__.py	`100.00% <ø> (ø)`
metacatalog/db/revisions/rev8.py	`60.00% <60.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 86ea28d...ab330f5. Read the comment docs.

mmaelicke commented 2 years ago

merged as version 0.4.7

VForWaTer / metacatalog

Update unit of electrical conductivity #163

Codecov Report