VForWaTer / metacatalog

Modular metadata management platform for environmental data.
https://vforwater.github.io/metacatalog
GNU General Public License v3.0
4 stars 1 forks source link

update datasource after setting data_names #178

Closed AlexDo1 closed 2 years ago

AlexDo1 commented 2 years ago

When fixing the tests in #159 I noticed that datasource.data_names was [Null] for the last datasource added.

This PR fixes this bug by always updating the datasource when importing data.

@mmaelicke should I open pull requests for small bugfixes like this or should I just push directly to master next time?

mmaelicke commented 2 years ago

I think it's worth it to open PR for each code change to main, in order to autogenerate changelogs.

For smaller fixes it's fine to directly merge after the tests succeeded, without code review.

Cool?

AlexDo1 commented 2 years ago

Sounds good!