VForWaTer / metacatalog

Modular metadata management platform for environmental data.
https://vforwater.github.io/metacatalog
GNU General Public License v3.0
3 stars 1 forks source link

Include keyword.value in Variable.to_dict() #210

Closed AlexDo1 closed 1 year ago

AlexDo1 commented 1 year ago

@mmaelicke

I currently only included the value of the associated keyword in Variable.to_dict(). 'value': 'ATMOSPHERIC TEMPERATURE'

Do we also need e.g. the path? 'path': 'EARTH SCIENCE > ATMOSPHERE > ATMOSPHERIC TEMPERATURE'

Or information about the thesaurus the keyword belongs to?

'name': 'GCMD',
'title': 'NASA/GCMD Earth Science Keywords',
'organisation': 'NASA',
'url': 'https://gcmdservices.gsfc.nasa.gov/kms/concepts/concept_scheme/sciencekeywords/?format=xml',
'description': 'NASA Global Clime change Master Dictionary Science Keywords'
codecov[bot] commented 1 year ago

Codecov Report

Merging #210 (37f3465) into master (fad845b) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #210   +/-   ##
=======================================
  Coverage   61.25%   61.25%           
=======================================
  Files          73       73           
  Lines        3407     3407           
=======================================
  Hits         2087     2087           
  Misses       1320     1320           
Flag Coverage Δ
e2e 61.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
metacatalog/models/variable.py 53.62% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.