Expand and fix unit tests for ImmutableResultSets - Githubissues

VForWaTer / metacatalog

Modular metadata management platform for environmental data.

https://vforwater.github.io/metacatalog

GNU General Public License v3.0

3 stars 1 forks source link

Expand and fix unit tests for ImmutableResultSets #229

Closed AlexDo1 closed 1 year ago

AlexDo1 commented 1 year ago

Since a few Pull Requests, unit tests fail again.

Line 176 fails: https://github.com/VForWaTer/metacatalog/blob/995c52224a20c165a9feb48c900cadcb99216668/metacatalog/test/test_api_add_find.py#L173-L176

dummy_results is a list of two ImmutableResultSets here.

__init__() does not accept an instance of type ImmutableResultSet anymore and we can delete all lines of code, where isinstance(instance, ImmutableResultSet) is checked: https://github.com/VForWaTer/metacatalog/blob/995c52224a20c165a9feb48c900cadcb99216668/metacatalog/util/results.py#L64 https://github.com/VForWaTer/metacatalog/blob/995c52224a20c165a9feb48c900cadcb99216668/metacatalog/util/results.py#L84-L86

We also need additional tests for ImmutableResultSets:

[x] Test that the ImmutableResultSet of an ImmutableResultSet is the same ImmutableResultSet via its checksum
[x] Test that ImmutableResultSets are never empty.
[x] Test .to_dict() method