search

VForWaTer / metacatalog

Modular metadata management platform for environmental data.
https://vforwater.github.io/metacatalog
GNU General Public License v3.0
3 stars 1 forks source link

Deprecate the behavior of `api.find_entry(contributors=None)` #252

Closed mmaelicke closed 1 year ago

mmaelicke commented 1 year ago 
          > > Closes #215
  • [x] add to the Entry.to_dictmethod
  • [x] change the Entry.from_dict] method
  • [x] add a test for this behavior explicitly
  • [x] check the api.find_person method for implementation
  • [ ] check the api.find_entry method for implementation

Looks good, did you also check the last checkpoint of the list?

I am on it right now... The contributor=None filter is actually doing the right thing, but filters for author and coAuthoronly. I suggest to deprecate this argument and inform users to use the newly created authors=None filter. Then, with 0.8.0 or 0.9.0, the contributors will run the same code without the filter for authors only. We should move this comment into a new issue.

Originally posted by @mmaelicke in https://github.com/VForWaTer/metacatalog/issues/248#issuecomment-1411699867