search

VForWaTer / metacatalog

Modular metadata management platform for environmental data.
https://vforwater.github.io/metacatalog
GNU General Public License v3.0
4 stars 1 forks source link

explicitly add is_partial to API #261

Closed mmaelicke closed 1 year ago

mmaelicke commented 1 year ago

closes #257

I also removed the geom attribute, which was still present in the API function add_entry, but does not exist on Entry anymore.

mmaelicke commented 1 year ago

@AlexDo1, removing the geom attribute from api.add_entry made at least one unittest to fail. Seems like there are still tests, that cover geom, although it's deprecated and we agreed to remove it.

AlexDo1 commented 1 year ago

api.add_entry() was still checking for geom in attr. I removed that code, tests are now working again.

mmaelicke commented 1 year ago

api.add_entry() was still checking for geom in attr. I removed that code, tests are now working again.

Great. Thanks! Then we can proceed...