VForWaTer / metacatalog

Modular metadata management platform for environmental data.
https://vforwater.github.io/metacatalog
GNU General Public License v3.0
4 stars 1 forks source link

Type hints #270

Closed mmaelicke closed 1 year ago

mmaelicke commented 1 year ago

closes #250

This is still draft. Not all API and model files are yet type hinted.

codecov[bot] commented 1 year ago

Codecov Report

Merging #270 (cd5264b) into main (74d32ce) will increase coverage by 0.45%. The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
+ Coverage   63.25%   63.70%   +0.45%     
==========================================
  Files          75       75              
  Lines        3693     3786      +93     
==========================================
+ Hits         2336     2412      +76     
- Misses       1357     1374      +17     
Flag Coverage Δ
e2e 63.70% <91.66%> (+0.45%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
metacatalog/api/add.py 51.65% <78.26%> (-0.56%) :arrow_down:
metacatalog/api/catalog.py 80.00% <81.81%> (-1.49%) :arrow_down:
metacatalog/ext/base.py 81.81% <83.33%> (ø)
metacatalog/models/license.py 76.31% <83.33%> (-0.83%) :arrow_down:
metacatalog/models/details.py 95.83% <87.50%> (-2.00%) :arrow_down:
metacatalog/models/variable.py 55.55% <88.88%> (ø)
metacatalog/models/keyword.py 90.74% <90.00%> (-1.42%) :arrow_down:
metacatalog/models/entry.py 68.37% <90.47%> (-0.20%) :arrow_down:
metacatalog/api/db.py 81.30% <90.90%> (-0.60%) :arrow_down:
metacatalog/models/entrygroup.py 86.76% <95.00%> (-0.93%) :arrow_down:
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mmaelicke commented 1 year ago

Thanks @AlexDo1! You can review again.