VForWaTer / metacatalog

Modular metadata management platform for environmental data.
https://vforwater.github.io/metacatalog
GNU General Public License v3.0
4 stars 1 forks source link

ISO 19115 API function #279

Closed AlexDo1 closed 1 year ago

AlexDo1 commented 1 year ago

This PR adds an API function to metacatalog.api.catalog for standard metadata export.

codecov[bot] commented 1 year ago

Codecov Report

Merging #279 (5b0e23c) into main (2d1d839) will increase coverage by 0.39%. The diff coverage is 96.00%.

@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
+ Coverage   63.67%   64.06%   +0.39%     
==========================================
  Files          75       75              
  Lines        3782     3829      +47     
==========================================
+ Hits         2408     2453      +45     
- Misses       1374     1376       +2     
Flag Coverage Δ
e2e 64.06% <96.00%> (+0.39%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
metacatalog/ext/standards_export/extension.py 97.10% <95.91%> (-2.90%) :arrow_down:
metacatalog/__version__.py 100.00% <100.00%> (ø)
metacatalog/api/find.py 64.13% <0.00%> (+0.39%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

AlexDo1 commented 1 year ago

A unittest is still missing.

@mmaelicke maybe you have an idea why create_standard_metadata does not return the ElementTree XML object.
When I call the function as it is at the moment without specifying path, the if statement in Line 237 is evaluated correctly, but xml is not returned... I don't get it.

image

mmaelicke commented 1 year ago

A unittest is still missing.

@mmaelicke maybe you have an idea why create_standard_metadata does not return the ElementTree XML object. When I call the function as it is at the moment without specifying path, the if statement in Line 237 is evaluated correctly, but xml is not returned... I don't get it.

image

I currently don't really get it. In any case, 'xml' is a really, really bad name for the variable as the module you are using there is also called 'xml'...

mmaelicke commented 1 year ago

A unittest is still missing. @mmaelicke maybe you have an idea why create_standard_metadata does not return the ElementTree XML object. When I call the function as it is at the moment without specifying path, the if statement in Line 237 is evaluated correctly, but xml is not returned... I don't get it. image

I currently don't really get it. In any case, 'xml' is a really, really bad name for the variable as the module you are using there is also called 'xml'...

Fixed this in https://github.com/VForWaTer/metacatalog/pull/279/commits/83df7acb6c7d3e69e958db76055cdb82f2ef9d34

AlexDo1 commented 1 year ago

@mmaelicke can you review? :)