VForWaTer / metacatalog

Modular metadata management platform for environmental data.
https://vforwater.github.io/metacatalog
GNU General Public License v3.0
4 stars 1 forks source link

Check extension for missing dependencies #282

Closed mmaelicke closed 1 year ago

mmaelicke commented 1 year ago

closes #277

codecov[bot] commented 1 year ago

Codecov Report

Merging #282 (4d8ed16) into main (cd5264b) will decrease coverage by 0.03%. The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main     #282      +/-   ##
==========================================
- Coverage   63.70%   63.68%   -0.03%     
==========================================
  Files          75       75              
  Lines        3786     3789       +3     
==========================================
+ Hits         2412     2413       +1     
- Misses       1374     1376       +2     
Flag Coverage Δ
e2e 63.68% <40.00%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
metacatalog/ext/__init__.py 49.01% <33.33%> (-0.99%) :arrow_down:
metacatalog/__version__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

AlexDo1 commented 1 year ago

I just tried to install metacatalog (pip install -e .) into a new conda environment and into a new venv environment to test this branch.
In both cases, dependencies are installed but then it does not go any further and hangs in Running setup.py develop for metacatalog. This does not only happen with this branch but also with the main branch.
I will try again tomorrow with a restarted computer, maybe the problem fixes itself...

AlexDo1 commented 1 year ago

Okay, the pip install -e . issue was a problem with my computer, the installation went smoothly today.

When trying to activate the standards_export extension with missing dependencies in the environment, a ModuleNotFoundError is produced:

ext.activate_extension('standards_export', 'metacatalog.ext.standards_export', 'StandardsExportExtension')

image

Running ext.__load_extensions() also produces the expected UserWarning: image

AlexDo1 commented 1 year ago

@mmaelicke I will approve when you had a look at my previous comment and also confirm that everything works as expected.

mmaelicke commented 1 year ago

@mmaelicke I will approve when you had a look at my previous comment and also confirm that everything works as expected.

Yeah, thanks! You can appove.