VForWaTer / metacatalog

Modular metadata management platform for environmental data.
https://vforwater.github.io/metacatalog
GNU General Public License v3.0
4 stars 1 forks source link

Add variable_names and dimension_name to DataSource #307

Closed AlexDo1 closed 10 months ago

AlexDo1 commented 10 months ago

This pull request adds variable_names to DataSource and dimension_name to TemporalScale and SpatialScale.
This allows for easier access of data. Additionaly, two Entries can connect to the same datasource but to different variables.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (881f6a0) 65.02% compared to head (519029e) 64.95%. Report is 2 commits behind head on main.

Files Patch % Lines
metacatalog/db/revisions/rev15.py 50.00% 6 Missing :warning:
metacatalog/models/datasource.py 64.28% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #307 +/- ## ========================================== - Coverage 65.02% 64.95% -0.08% ========================================== Files 75 76 +1 Lines 3880 3903 +23 ========================================== + Hits 2523 2535 +12 - Misses 1357 1368 +11 ``` | [Flag](https://app.codecov.io/gh/VForWaTer/metacatalog/pull/307/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VForWaTer) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/VForWaTer/metacatalog/pull/307/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VForWaTer) | `64.95% <62.06%> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VForWaTer#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.