Closed mmaelicke closed 4 years ago
Merging #86 into master will increase coverage by
0.29%
. The diff coverage is35.71%
.
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
+ Coverage 43.24% 43.54% +0.29%
==========================================
Files 39 39
Lines 1466 1479 +13
==========================================
+ Hits 634 644 +10
- Misses 832 835 +3
Flag | Coverage Δ | |
---|---|---|
#e2e | 43.54% <35.71%> (+0.29%) |
:arrow_up: |
Impacted Files | Coverage Δ | |
---|---|---|
metacatalog/api/add.py | 44.04% <0.00%> (-0.54%) |
:arrow_down: |
metacatalog/models/license.py | 60.00% <41.66%> (-10.84%) |
:arrow_down: |
metacatalog/db/migration.py | 87.50% <0.00%> (+25.00%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5345663...a9275e1. Read the comment docs.
There are some fundamental questions, that I am not happy with. I included a set of licenses into the default list of licenses. But I also included
noDerivative
(ND
) andNonCommerical
(NC
) licenses. I am not even sure about using theShareAlike
(SA
) licenses.ND
andNC
are considered to be non-free licenses as particular kinds of usage are not allowed. As far as I know,ND
would mean that any kind of remixing and building on the data is not allowed. Thus if a user downloads data, he would not be allowed to share or publish i.e. a modeling result. Even withSA
I am not sure, although used all over the place. If I use data to make a graph, I have to share the graph with the same or an alike license. If the graph is published i.e. in HESS, it is published under a by attribution only license and anyone could use and distribute it under other terms (likeNC
). Thus the user would have to request permission every time he uses the data....