search

VForWaTer / metacatalog

Modular metadata management platform for environmental data.
https://vforwater.github.io/metacatalog
GNU General Public License v3.0
3 stars 1 forks source link

keyword rework #90

Closed mmaelicke closed 4 years ago

mmaelicke commented 4 years ago

resolves #70 close #73 resolves #75

codecov[bot] commented 4 years ago

Codecov Report

Merging #90 into master will decrease coverage by 0.95%. The diff coverage is 36.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
- Coverage   43.22%   42.27%   -0.96%     
==========================================
  Files          39       39              
  Lines        1483     1540      +57     
==========================================
+ Hits          641      651      +10     
- Misses        842      889      +47
Flag Coverage Δ
#e2e 42.27% <36.36%> (-0.96%) :arrow_down:
Impacted Files Coverage Δ
metacatalog/api/_mapping.py 100.00% <ø> (ø)
metacatalog/db/session.py 17.74% <0.00%> (-0.30%) :arrow_down:
metacatalog/api/find.py 52.17% <11.11%> (-5.47%) :arrow_down:
metacatalog/api/add.py 42.13% <16.66%> (-1.92%) :arrow_down:
metacatalog/models/keyword.py 63.63% <53.57%> (-13.04%) :arrow_down:
metacatalog/api/db.py 81.70% <66.66%> (-1.63%) :arrow_down:
metacatalog/models/__init__.py 100.00% <100.00%> (ø)
metacatalog/db/migration.py 37.50% <0.00%> (-25.00%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0e0809f...30f430c. Read the comment docs.

mmaelicke commented 4 years ago

I'll merge this anyway, as the coverage drops are due to the migration test deactivation.

First have to figure out, what exactly is going wrong on migration tests, as the mirgations themsevles are working fine.