search

VForWaTer / scripts

Notebook collection for different purposes
0 stars 0 forks source link

Missing operator metadata #3

Closed AlexDo1 closed 3 years ago

mmaelicke commented 3 years ago

Hey @AlexDo1,

nice work! I have some small questions:

  1. Is there a reason, why the citation is commented out?
  2. Can you remove Uwe from the LUBW and DWD entry, because he is not part of these institutions. Does the Model accept the entries without first and last name? (Not sure)
  3. The DWD has a custom Nutzungslizenz, and I think the LUBW as well. Can you quickly check that online? Maybe we need to import them into the DB. I dno't think that these two institutions are fine with CC BY 4.0
AlexDo1 commented 3 years ago
  1. citation is commented out because the add_person() function does not have an argument citation and trying to use the argument gives the error TypeError: add_person() got an unexpected keyword argument 'citation'
  2. Trying to add a person without the first_name and last_name arguments results in the following error: TypeError: add_person() missing 2 required positional arguments: 'first_name' and 'last_name', setting first_name=None and last_name=None works, the persons are added to metacatalog with [null] as first and last name.
  3. I couldn´t find a general Nutzungslizenz for the DWD and the LUBW, as far as I understand it depends on which products or services you use from these institutions. Here is something about the 'GeoNutzV' which applies for spatial data and spatial data services available for free access from the DWD, but I´m not sure if this is what we are looking for.
mmaelicke commented 3 years ago
  1. citation is commented out because the add_person() function does not have an argument citation and trying to use the argument gives the error TypeError: add_person() got an unexpected keyword argument 'citation'

Good to know. Can you please open an issue in metacatalog to add that opion? You can then either assign yourself to implement it, or assign me to do it. We will merge this PR anyway and can later on update the person entries

  1. Trying to add a person without the first_name and last_name arguments results in the following error: TypeError: add_person() missing 2 required positional arguments: 'first_name' and 'last_name', setting first_name=None and last_name=None works, the persons are added to metacatalog with [null] as first and last name.

This is still not ideal. I will come up with an idea, or discuss this with sibylle again. Therefore we will wait with merge until I have an answer

  1. I couldn´t find a general Nutzungslizenz for the DWD and the LUBW, as far as I understand it depends on which products or services you use from these institutions. Here is something about the 'GeoNutzV' which applies for spatial data and spatial data services available for free access from the DWD, but I´m not sure if this is what we are looking for.

I will check this again. I am pretty sure there is something...

mmaelicke commented 3 years ago

Concerning point 2: We don't upload the DWD and LUBW data right now, as VFORWATER will always need an actual contact person. Thus, you can remove the data for now.