Closed AlexDo1 closed 3 years ago
citation
is commented out because the add_person() function does not have an argument citation
and trying to use the argument gives the error TypeError: add_person() got an unexpected keyword argument 'citation'
first_name
and last_name
arguments results in the following error: TypeError: add_person() missing 2 required positional arguments: 'first_name' and 'last_name'
, setting first_name=None
and last_name=None
works, the persons are added to metacatalog with [null] as first and last name.
citation
is commented out because the add_person() function does not have an argumentcitation
and trying to use the argument gives the errorTypeError: add_person() got an unexpected keyword argument 'citation'
Good to know. Can you please open an issue in metacatalog to add that opion? You can then either assign yourself to implement it, or assign me to do it. We will merge this PR anyway and can later on update the person entries
- Trying to add a person without the
first_name
andlast_name
arguments results in the following error:TypeError: add_person() missing 2 required positional arguments: 'first_name' and 'last_name'
, settingfirst_name=None
andlast_name=None
works, the persons are added to metacatalog with [null] as first and last name.
This is still not ideal. I will come up with an idea, or discuss this with sibylle again. Therefore we will wait with merge until I have an answer
- I couldn´t find a general Nutzungslizenz for the DWD and the LUBW, as far as I understand it depends on which products or services you use from these institutions. Here is something about the 'GeoNutzV' which applies for spatial data and spatial data services available for free access from the DWD, but I´m not sure if this is what we are looking for.
I will check this again. I am pretty sure there is something...
Concerning point 2: We don't upload the DWD and LUBW data right now, as VFORWATER will always need an actual contact person. Thus, you can remove the data for now.
Hey @AlexDo1,
nice work! I have some small questions:
citation
is commented out?