VGVentures / very_good_engineering

Static site for Very Good Engineering created with AstroJS. All of our best practices, tips, tricks, and demos in one convenient place!
https://engineering.verygood.ventures
10 stars 0 forks source link

docs: include test dependency and random test information #64

Closed alestiago closed 1 month ago

alestiago commented 2 months ago

Includes two new practices:

alestiago commented 2 months ago

Running the formatter (npm run format) messes with the actual expected result, introducing unintended characters and providing wrong indentation, for example it results on:

group(\_Counter, () {
late \_Counter counter;

I'm currently not quite sure what's causing such behavior but it's a consequence of applying @jsgalarraga suggestion on https://github.com/VGVentures/very_good_engineering/pull/64#discussion_r1741698863.

alestiago commented 2 months ago

Formatting has now been resolved, it seems that new lines are needed to avoid the formatter having unexpected ~brain seizures~ results.

alestiago commented 2 months ago

@marwfair @jolexxa, since @jsgalarraga approved, it can now be merged. However, I'll wait until I hear feedback from either of you before merging these practices in.

alestiago commented 1 month ago

@jolexxa I need a re-review from you here since your requested changes are blocking the effort from being merged in.