search

VGamezz19 / react-native-sketch-draw

🔵React Native (v0.53) 🎨Component for touch based drawing supporting iOS and Android.
MIT License
34 stars 9 forks source link

Update gradle #6

Closed cristianoccazinsp closed 5 years ago

cristianoccazinsp commented 5 years ago

Please update gradle version, and also the config so android sdk versions are not hardcoded, something like this:

android {
        compileSdkVersion rootProject.ext.compileSdkVersion
        buildToolsVersion rootProject.ext.buildToolsVersion

        defaultConfig {
            minSdkVersion rootProject.ext.minSdkVersion
            targetSdkVersion rootProject.ext.targetSdkVersion
            versionCode 1
            versionName "1.0"
        }
        lintOptions {
            abortOnError false
        }
    }
cristianoccazinsp commented 5 years ago

Also would be a good idea to update the actual gradle to get rid of 

> Configure project :react-native-sketch-draw
WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'.
It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html