VGraphRNN / VGRNN

Variational Graph Recurrent Neural Networks - PyTorch
114 stars 32 forks source link

Incorrect use of torch.nn.utils.clip_grad_norm #4

Closed zazyzaya closed 3 years ago

zazyzaya commented 4 years ago

In both training examples clip_grad_norm() is called after opt.step() so it isn't doing anything. It should either be removed or moved before the optimizer updates the model components