search

VHDL-LS / rust_hdl_vscode

VHDL Language Support for VSCode
MIT License
53 stars 17 forks source link

Updated vhdl.tmLanguage from Pull Request in textmate repo #65

Closed guilbaudl closed 1 year ago

guilbaudl commented 1 year ago

Hello there, After reading the updated readme, I figured that the syntax highlight causing some issues in the vhdl server is due to textmate file. One pull request exists on this repo where the fixes have been done. I just added the changes in this pull request. See https://github.com/textmate/vhdl.tmbundle/pull/3 for details of the changes (original pull request)

GlenNicholls commented 1 year ago

Changing from spaces to tabs makes the diff pretty awful at first glance - ignoring whitespace in the diff mostly fixes it, but I don't know why spacing was changed in the first place. Maybe your IDE settings enabled changing the spacing on file save...?

I recommend changing it back and also configuring your editor to adopt conventions used in the current file to avoid this in the future. I did a quick glance and this repo uses spaces, so I would stick with the local convention for consistency

bpadalino commented 1 year ago

I don't think the right thing to do is to use that grammar anyway. It really was meant to provide the editor with context, but the language server is doing that now.

I have submitted #66 which is an updated syntax-only grammar that has been updated for VHDL-2019 as well. I recommend closing this PR and focusing the efforts on #66 to make it as correct as possible.