search

VHDL / pyVHDLModel

An abstract language model of VHDL written in Python.
https://vhdl.github.io/pyVHDLModel/
Other
48 stars 9 forks source link

Fix package namespace bugs #82

Closed Tcenova closed 1 month ago

Tcenova commented 1 month ago

Bug Fixes

Paebbels commented 1 month ago

@Tcenova did the merged version run in your report by a GitHub pipeline?

Since GitHub got stupid about pipelines, I can't see any pipeline running for contributions to check for correctness. I need to merge it and see it fail in my account. Previously, it started a pipeline in the fork and displayed the results in my pipeline overview too.

Paebbels commented 1 month ago

I pushed a fixed version to dev.

Tcenova commented 1 month ago

@Tcenova did the merged version run in your report by a GitHub pipeline?

I am not sure. I have never used GitHub pipelines before. Where would I check?

Paebbels commented 1 month ago

I checked here: https://github.com/Tcenova/pyVHDLModel/actions

Hmmm there is no pipeline. WTF has GitHub changed ... This explains why I see no results, but why does it not launch in your account/fork...?

Tcenova commented 1 month ago

Ah. Because it defaults to not running in forks. I get the message:

Workflows aren’t being run on this forked repository Because this repository contained workflow files when it was forked, we have disabled them from running on this fork. Make sure you understand the configured workflows and their expected usage before enabling Actions on this repository.

I get an option to enable them on the fork. I will do so, so hopefully it will run if I end up submitting other PRs.

I do see a code check on this PR under the "Checks" tab which links to: https://app.codacy.com/gh/VHDL/pyVHDLModel/pull-requests/82/issues

Paebbels commented 1 month ago

Please activate and lets see if it works next time.

The latter was fixed by ma new push. the f-string can be converted to a normal string.