Closed gmarkomanolis closed 5 years ago
Hey George,
In your commit message, you say, "io500.sh needs to be changed to regular if we decide to accept the merging." So, perhaps you can add that now so that everything is done in one pull request?
Julian/Jay, do you two agree that the approach George and I are on is a good approach?
Thanks,
John
On Wed, Oct 16, 2019 at 9:25 AM George Markomanolis < notifications@github.com> wrote:
Merge the last changes to the master branch. io500.sh needs to be changed to regular if we decide to accept the merging.
We use the latest IOR and if it's one node used, we add -Y for mdtest easy/hard write.
You can view, comment on, or merge this pull request online at:
https://github.com/VI4IO/io-500-dev/pull/52 Commit Summary
- editing io500.sh to use always scc for the student cluster competition and using last IOR hashtag to include the changed for the -Y option for mdtest. This is mainly for the Student Cluster Competition and it fixes an observed mdtest issue with single node execution
- if in the IOR easy output is declared that it's used one node, then use -Y in mdtest eash and hard write phases
- Use newer IOR version to include the fix for -Y and mdtest as also IOR -F -u
File Changes
- M io500.sh https://github.com/VI4IO/io-500-dev/pull/52/files#diff-0 (2)
- M utilities/io500_fixed.sh https://github.com/VI4IO/io-500-dev/pull/52/files#diff-1 (12)
- M utilities/prepare.sh https://github.com/VI4IO/io-500-dev/pull/52/files#diff-2 (2)
Patch Links:
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/VI4IO/io-500-dev/pull/52?email_source=notifications&email_token=AAPT2PTOUL7N6ZD64TKZAPTQO4W67A5CNFSM4JBNF6L2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HSGKS2A, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPT2PRA5ZJXND3ZZ6LCY4TQO4W67ANCNFSM4JBNF6LQ .
That is basically the approach we discussed at the phone call, so I'm good with it. Like said, we could keep the OLD ior hash to use and bump it forward in the IOR repository!
I agree with this approach too
Best,
Jay
On Oct 16, 2019, at 11:32 AM, Julian Kunkel notifications@github.com wrote:
That is basically the approach we discussed at the phone call, so I'm good with it. Like said, we could keep the OLD ior hash to use and bump it forward in the IOR repository!
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/VI4IO/io-500-dev/pull/52?email_source=notifications&email_token=AAUR4WWY4Z6KZM46ZFYMRSTQO4XXBA5CNFSM4JBNF6L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBM5WUQ#issuecomment-542759762, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAUR4WQK55QYBWIZFOBLWZLQO4XXBANCNFSM4JBNF6LQ.
Is it easy to create a new logical tag like io500-sc19v2 instead of a69a5916cf0a057?
On Wed, Oct 16, 2019 at 11:52 AM Julian Kunkel notifications@github.com wrote:
@JulianKunkel commented on this pull request.
In utilities/prepare.sh https://github.com/VI4IO/io-500-dev/pull/52#discussion_r335622814:
@@ -7,7 +7,7 @@ echo It will also attempt to build the benchmarks echo It will output OK at the end if builds succeed echo
-IOR_HASH=io500-sc19 +IOR_HASH=a69a5916cf0a057
Please revert this. Let me bump the hash at the IOR repository to a69a5916cf0a057 As we figured there is an issue that affects everyone.
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/VI4IO/io-500-dev/pull/52?email_source=notifications&email_token=AAPT2PTMDZBAJ2JF3G5MYA3QO5IFDA5CNFSM4JBNF6L2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIF5BFA#pullrequestreview-302764180, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPT2PSPDCL3XVBOFIZN5CDQO5IFDANCNFSM4JBNF6LQ .
Merge the last changes to the master branch. io500.sh needs to be changed to regular if we decide to accept the merging.
We use the latest IOR and if it's one node used, we add -Y for mdtest easy/hard write.