search

VIDA-NYU / domain_discovery_tool_deprecated

Seed acquisition tool to bootstrap focused crawlers
23 stars 8 forks source link

Revert "Bokeh Clustering Plot" #55

Closed yamsgithub closed 8 years ago

yamsgithub commented 8 years ago

Reverts ViDA-NYU/domain_discovery_tool#51

Reverting as the changes are affecting query based filtering.

yamsgithub commented 8 years ago

@brittainhard I had to revert the pull request as I noticed that the "Select Queries" is not working with your changed. Could you please check this?

brittainhard commented 8 years ago

@yamsgithub what exactly is "Select Queries" ?

yamsgithub commented 8 years ago

Its when you select "Queries" in the page filtering which shows a "Select Queries" button. When you click on the button it should show a modal with the current queries for that domain. The modal does not show up properly

brittainhard commented 8 years ago

I'm still not seeing this on the page. Where on the page is this located?

brittainhard commented 8 years ago

@yamsgithub I think I see it now. This was added while I was working on my PR, if I recall. I'll try to get it working

brittainhard commented 8 years ago

This should be a simple fix. Somewhere, vis.queries is being set to undefined. I just have to find out where. Also there is a small UI issue to fix.

brittainhard commented 8 years ago

@yamsgithub can we close this since we fixed the problems with the clustering plot?

yamsgithub commented 8 years ago

I think we can do this. Just one more problem that is more immediate to fix.

The URLs tooltip is very annoying as it appears as you move the mouse over the circles. Can you please change this to appear only when the mouse is no longer moving?

You can check the behaviour on the D3 version.

yamsgithub commented 8 years ago

I am guessing this should be a quick fix?

brittainhard commented 8 years ago

@yamsgithub i am currently working on the statistics dashboard PR, but I will be more than willing to fix these issues after we merge the dashboard code. I think it might be a good idea to rewrite https://github.com/ViDA-NYU/domain_discovery_tool/issues/52 to reflect the problems with the current graph? Would you mind putting all of these issues there?

yamsgithub commented 8 years ago

OK...we can close this and I can open one with all the issues that need to be fixed.