VIDA-NYU / tile2net

Automated mapping of pedestrian networks from aerial imagery tiles
BSD 3-Clause "New" or "Revised" License
148 stars 23 forks source link

Oregon tile support #12

Closed dhodcz2 closed 1 year ago

dhodcz2 commented 1 year ago
          Would greatly appreciate having Oregon added to the supported region catalogue. Imagery from 2017/2018 is currently publicly available, and splits between:

Originally posted by @sylvan-sh in https://github.com/VIDA-NYU/tile2net/issues/11#issuecomment-1513478999

dhodcz2 commented 1 year ago

Oregon has been implemented on tile2net/dhodcz2. However, we are unable to retrieve tiles due to an SSL error:

requests.exceptions.SSLError: HTTPSConnectionPool(host='imagery.oregonexplorer.info', port=443): Max retries exceeded with url: /arcgis/rest/services/OSIP_2018/OSIP_2018_WM/ImageServer/tile/19/190540/82893 (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:997)')))

requests.get(verify=False) resolves the error, however that is not an acceptable solution. Are you associated with Oregon Explorer? Is this source only intended to be available to users affiliated with Oregon Explorer? @sylvan-sh

jthiard commented 1 year ago

The SSL certificate for imagery.oregonexplorer.info is OK when opening in a browser, but verification will fail when trying from python requests or curl

$ curl -I https://imagery.oregonexplorer.info
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.haxx.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

Usually it means that the SSL chain is not properly configured on the server which fails to seend one or many intermediate certificates. Browsers use a big curated list of trusted certificates to avoid this error in most case, but tools like python requests does not (not part of the job!). See https://github.com/psf/requests/issues/2959#issuecomment-168961838 for a better explanation.

The best option is to contact the server admin to report the issue and get this fixed upstream.

sylvan-sh commented 1 year ago

@jthiard, your explanation is very helpful, as I was seeing the same thing. I have some contacts I can reach out to that are affiliated with the source, and hopefully we can get this resolved. Will update once I hear something.

Mary-h86 commented 1 year ago

@jthiard Thank you for the helpful comment! @sylvan-sh Would be great if you could reach out to your contacts there and update us, so we can resolve the issue and you can easily use Tile2Net for your region!

Mary-h86 commented 1 year ago

@sylvan-sh Hi Sylvan, Do you have any updates on the Oregon tiles?

sylvan-sh commented 1 year ago

Unfortunately, nothing definitive. The correct people to make the change have been informed, but that happened back in late April after you, @Mary-h86, and @jthiard helped identify the issue. I'm still actively pursuing getting this resolved, ideally w/ even more current tiles, and will jubilantly post to this issue once accomplished.

Mary-h86 commented 1 year ago

@sylvan-sh Thanks for the update! Looking forward to adding Oregon to our list of supported cities! I am closing this issue for now, please feel free to re-open whenever you have the updated images available!

sylvan-sh commented 11 months ago

@Mary-h86, exciting news! I believe the certificate issue has now been addressed. Additionally, we have a new tile set that both provides a unified Oregon set and was collected in 2022. I just ran a mid-sized city in Oregon w/ the 2022 imagery, and it looks like everything executed w/o problems. Thank you for being so patient while the process for a fix played out.

Mary-h86 commented 11 months ago

@Mary-h86, exciting news! I believe the certificate issue has now been addressed. Additionally, we have a new tile set that both provides a unified Oregon set and was collected in 2022. I just ran a mid-sized city in Oregon w/ the 2022 imagery, and it looks like everything executed w/o problems. Thank you for being so patient while the process for a fix played out.

That's great!! Happy to hear and thank you for sharing it with us!