search

VIDI-X / M5Stack-SD-Updater-1.0.2

M5Stack Updater library fork for VIDI X microcomputer
MIT License
1 stars 0 forks source link

Feedback #1

Open tobozo opened 2 years ago

tobozo commented 2 years ago

Hi,

This isn't really an issue, I just want to thank you for choosing my library for your awesome project :+1:

I'm curious as why you didn't just fork the initial project though. I'd be happy to add official support for VIDI-X (and links) to the M5Stack-SD-Updater library.

I'm also curious about why you picked version 1.0.2 though, what should I do to make the latest version fit to your needs ?

be well

tobozo

VIDI-X commented 2 years ago

Hi,

I tried to run the newer library but, I got a compile error.

`Arduino:1.8.19 (Windows 10), Ploča: "ODROID ESP32, QIO, 80MHz, Default, 921600, None" In file included from C:\Users\Podrska\Documents\Arduino\chess\chess.ino:16:0: C:\Users\Podrska\Documents\Arduino\libraries\M5Stack-SD-Updater\src/M5StackUpdater.h:152:88: error: missing binary operator before token "("

if defined ESP_ARDUINO_VERSION && ESP_ARDUINO_VERSION >= ESP_ARDUINO_VERSION_VAL(2,0,0)

                                                                                    ^

Multiple libraries were found for "WiFi.h" Used: C:\Users\Podrska\AppData\Local\Arduino15\packages\esp32\hardware\esp32\1.0.4\libraries\WiFi Not used: C:\Program Files (x86)\Arduino\libraries\WiFi Multiple libraries were found for "SD.h" Used: C:\Users\Podrska\AppData\Local\Arduino15\packages\esp32\hardware\esp32\1.0.4\libraries\SD Not used: C:\Program Files (x86)\Arduino\libraries\SD Not used: C:\Users\Podrska\Documents\Arduino\libraries\SD exit status 1 Error compiling for board ODROID ESP32.`

I'm not sure if the Chess code which has also been downloaded from somewhere on the internet or something else is causing the error.

I'll try to figure out the problem and let you know what I found. For now, I know that the Chess code works with libraries 1.0.2 and 1.0.3, but it doesn't work with libraries 1.1.0 and 1.2.0, and probably those between.

I would be wery glad if a newer library would work and have VIDI X in the list of supported boards.

Be Well

tobozo commented 2 years ago

thanks for your feedback :+1: 

(...)packages\esp32\hardware\esp32\1.0.4(...)

wow arduino-esp32 1.0.4 is quite old (2019), I'll see what I can do to fix this compile error and add followup to this post

just out of curiosity: why use arduino-esp32 1.0.4 when the lastest stable version is 2.0.4 ?

tobozo commented 2 years ago

looking at the Chess.ino code (here's the probable source) ... I just can't compile it when I set the compiler warnings to All, which means there are other errors to fix first, for example it's using #include <arduino.h> instead of #include <Arduino.h> and gives an include error on linux/mac systems.

image

Another WTF is the Serial being started twice:

  Serial.begin(115200);
  Serial.flush();
  Serial.println(F("Start"));
  M5.begin();

Problem: M5.begin() also calls Serial.begin() behind the hood and this may freeze the UART long enough for the SDUpdater to skip the menu and ignore the startup commands. Could that be the reason for the library not working?

So in the setup() it should be more like:

  //Serial.begin(115200);
  //Serial.flush();
  //Serial.println(F("Start"));
  M5.begin();
  Serial.println(F("Start"));