search

VILLASframework / web

The VILLASweb frontend (website) for planning, controlling, monitoring and analysing distributed simulations.
https://fein-aachen.org/en/projects/villas-web/
GNU General Public License v3.0
3 stars 3 forks source link

Flux to redux migration #421

Closed iripiri closed 1 week ago

iripiri commented 6 months ago

Branch to complete Flux to redux migration of VILLASweb.

Based on Amirs work in https://github.com/amirrr/web/tree/redux-migration

amirrr commented 4 months ago

@iripiri Did you guys resolve the issue?

iripiri commented 4 months ago

@iripiri Did you guys resolve the issue?

Hi @amirrr, to sign-off your commits, I need you to follow these steps:

  1. Checkout the branch "amend-amirs-commits-signoff"

    git clone git@github.com:VILLASframework/web.git
cd web
git checkout amend-amirs-commits-signoff

  2. Rebase all your commits (except the one of @Anyandsi)

    git rebase -i HEAD~9

    Mark each commit except the last one for editing by changing "pick" to "edit".

  3. Amend each commit (this needs to be done 8 times)

    git commit --amend --signoff
git rebase --continue

  4. Push your changes

    git push origin amend-amirs-commits-signoff

I've tested this and deleted the corresponding pull request (I don't want to sign-off your commits), that resolved the DCO fails. I will create the pull request and merge the changes into the flux-to-redux-migration branch.

Thank you so much!

iripiri commented 2 months ago

I signed-off the commits of @amirrr now, because several attempts were unsuccessful and he has not been employed at the institute for half a year now. I needed to force push, so I am not sure whether signing off would have worked for him anyway.