VIN-y / MissChanger

A Stealth Burner tool changer system for Voron 2.4 and Trident.
https://discord.gg/Gt5XCCwv
GNU General Public License v3.0
67 stars 2 forks source link

z-offset is not correctly saved #28

Open VIN-y opened 2 weeks ago

VIN-y commented 2 weeks ago

when you click SAVE_CONFIG after baby stepping, the result is saved as:

#*# [tool_probe_endstop]
#*# z_offset = -0.647

which is wrong and not going to be used in to the system regardless.

It is good that the values does not overwrite or messed up other values if the accidental clicks were to happened. However, it would be nice to be able to retain the various way to save the baby step results.

VIN-y commented 2 weeks ago

@goncastrum I don't know how familiar with Github and all of that. Regardless, linking to some random file with the most generic description there is, i.e.:

to fix your trouble try this fix

is the best way to get reported and blocked.

So explain yourself, before I do that.

iam-py-test commented 2 weeks ago

@VIN-y they are a known spam bot. The MediaFire link downloads a password-protected archive containing an unknown piece of malware: https://github.com/hagezi/dns-blocklists/issues/3598 https://www.virustotal.com/gui/file/1f79a95f6bde6c375a9d60dfba8c02fd463d2cbe1d2d7a38eaa0ba403d3529d0/detection The uBlock Origin team has created a GitHub Actions script to detect and remove these comments: https://github.com/uBlockOrigin/uAssets/blob/master/.github/workflows/on-issue-comment.yml While it is effective, I am concerned about false positives. Thanks

VIN-y commented 1 week ago

Interestingly. Different material prefers different z-offset on the same tool-head. So more work need to be done per tool-head after the calibration via the calibration probe. The Nudge probe works fantastically for multi-colour tool-changes.

VIN-y commented 1 week ago

What I have been doing so far is to let the system safe the default (but is now irrelevant) variable [tool_probe_endstop]. Then manually go to printer.cfg to copy-paste the value to the correct section.