VIS-2 taobank-04-24 issues

VIS-2 / taobank-04-24

0 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Unused imports

#44 DanailYordanov opened 4 months ago
0
`TBANKStaking::takeFees()` always returns `true`

#43 DanailYordanov opened 4 months ago
0
Unbounded view functions can fail

#42 DanailYordanov opened 4 months ago
0
If-statement never reached in `StabilityPool::_updateP()`

#41 DanailYordanov opened 4 months ago
0
USDC blacklist functionality can lock depositor collateral rewards

#40 DanailYordanov opened 4 months ago
0
Non-compliance with function ordering in Solidity Style Guide

#39 DanailYordanov opened 4 months ago
0
Use of named imports is advisable

#38 DanailYordanov opened 4 months ago
0
Floating compiler version

#37 DanailYordanov opened 4 months ago
0
Known vulnerabilities in current version of OpenZeppelin contracts

#36 DanailYordanov opened 4 months ago
0
Adopt named mappings for clarity

#35 DanailYordanov opened 4 months ago
0
Owner can renounce ownership

#34 DanailYordanov opened 4 months ago
0
Missing events

#33 DanailYordanov opened 4 months ago
0
Risk of locked funds inside `VaultFactoryZapper`

#32 DanailYordanov opened 4 months ago
0
Risk of auction duration modification in `AuctionManager`

#31 DanailYordanov opened 4 months ago
1
The liquidation auction doesn't allow bidders to specify maximum bid price

#30 DanailYordanov opened 4 months ago
0
Minimal borrowed amounts can grief protocol, leading to underwater debt

#29 DanailYordanov opened 4 months ago
0
`StabilityPool` `stableCoin` variable not updated alongside factory

#28 DanailYordanov opened 4 months ago
0
Increments/decrements can be unchecked in for-loops

#27 0xMilenov opened 4 months ago
0
Revert strings are less gas-efficient than custom errors

#26 0xMilenov opened 4 months ago
0
Store array length outside loops for efficiency

#25 0xMilenov opened 4 months ago
0
Missing `contributorDeposit` check in `StabilityPool::redeemReward()`

#24 0xMilenov opened 4 months ago
0
Use of `override` is unnecessary

#23 0xMilenov opened 4 months ago
0
Unresolved TODO and stale comments in the code

#22 0xMilenov opened 4 months ago
0
Recommendation to use `uint48` for time-centric variables

#21 0xMilenov opened 4 months ago
0
Use of abi.encodePacked() with dynamic types

#20 0xMilenov opened 4 months ago
1
The risks of relying on assert() in solidity contracts

#19 0xMilenov opened 4 months ago
0
ERC20 tokens with more than 18 decimals cause reverts

#18 0xMilenov opened 4 months ago
0
`Ownable2Step` is preferred over `Ownable`

#16 0xMilenov opened 4 months ago
0
OpenZeppelin ERC20 `safeApprove()` is deprecated

#15 0xMilenov opened 4 months ago
0
Incompliance With ERC-20 Standard

#14 0xMilenov opened 4 months ago
0
First staker can drain `TBANKStaking` contract

#12 DanailYordanov opened 4 months ago
0
Incorrect borrow rate calculation leads to user funds loss

#11 DanailYordanov opened 4 months ago
0
1:1 ratio is assumed when minting and burning in `Stabilizer.sol`

#10 DanailYordanov opened 4 months ago
0
Dutch auction poses disadvantages for bidders

#9 DanailYordanov opened 4 months ago
4
No check for sequencer uptime can lead to dutch auctions executing at bad prices

#8 DanailYordanov opened 4 months ago
4
Gas Optimizations

#7 0xMilenov closed 4 months ago
0
Informational Issues

#6 0xMilenov closed 4 months ago
0
Low Risk Issues

#5 0xMilenov closed 4 months ago
6
Chainlink price feed good practices

#4 DanailYordanov opened 4 months ago
0
User can lose money paying someone else's debt

#3 0xMilenov opened 4 months ago
0
Possibility of a reorg attack

#2 0xMilenov opened 4 months ago
0