CBR Shooter replay view should now be more or less in compliance with MVVM.
Although it may not be ideal yet (we can adjust some things when we are going to refactor the UI code), I roughly
saved 200-300 lines of code compared to the previous messy approach. The frame based stats object is bound between
view and viewmodel, so that the view can retrieve the current information for any map update easily.
The viewmodel now aims at only providing information for the view and does not contribute in how to actually display the data.
Furthermore the replay view is working extremely stable even if you stress it with high velocity and bouncing the frame slider
back and forth it will genuinely adjust all information as you would expect it!
PR will be merged right away, because it does not break anything.
@VocalTrance please feel free to branch out from dev and make some additional formal changes, I feel like I am so done
with this CBR shooter replay view for now xD
... Also fixes a little UI bug of the session view, which probably arose by prior merging
CBR Shooter replay view should now be more or less in compliance with MVVM.
Although it may not be ideal yet (we can adjust some things when we are going to refactor the UI code), I roughly saved 200-300 lines of code compared to the previous messy approach. The frame based stats object is bound between view and viewmodel, so that the view can retrieve the current information for any map update easily. The viewmodel now aims at only providing information for the view and does not contribute in how to actually display the data.
Furthermore the replay view is working extremely stable even if you stress it with high velocity and bouncing the frame slider back and forth it will genuinely adjust all information as you would expect it!
PR will be merged right away, because it does not break anything.
@VocalTrance please feel free to branch out from dev and make some additional formal changes, I feel like I am so done with this CBR shooter replay view for now xD
... Also fixes a little UI bug of the session view, which probably arose by prior merging
Adding reviewers for notice of this PR.