search

VISAB-ORG / VISAB

VISAB is a standalone utility to visualize artificial intelligence agent behavior in games.
1 stars 0 forks source link

E refactor newgui #112

Closed mfroeh closed 3 years ago

mfroeh commented 3 years ago

Refactored newgui

Purged most TODOs. There is still one in SettlersReplayView and one when loading the images for the SessionOverview, since we don't have an default image, CBRShooters image is used. I think we can just leave the latter in.

Slightly more performant live views. I tried using synchronized to lock the statistics of the file and in turn avoid concurrent modification, but this was far to performance costly. Thus I implemented a workaround where we atleast only create one copy of the statistics list upon updating the data.

Besides that I did more tiny stuff that crossed my eyes.

What is still left to do? In my opinion, its totally fine to not javadoc specific implementations for the games. New games will always be implemented against the base classes / interfaces. Comments within method bodies however, may be useful to understand whats going on. Generally this is already done where it matters I think, but feel free to check it again.

The only todo regarding refactoring I can think of is to check on the package.info files again. I did some of these in the other packages, but haven't done them in gui yet.

I will merge this instantly, since working with a different state would truly be catastrophic.

mfroeh commented 3 years ago

I also deleted all existing branches besides master, dev and initial_version so that its clear that we should work on the new state. If you have a local branch with changes whose remote I just removed, just recreate it by git push -u origin BRANCH_NAME.