search

VISAB-ORG / VISAB

VISAB is a standalone utility to visualize artificial intelligence agent behavior in games.
1 stars 0 forks source link

E settings redesign #60

Closed leRoe93 closed 3 years ago

leRoe93 commented 3 years ago

Here is my proposal on how to deal with the settings from now on.

The ConfigManageris used to access all general settings and this is why it now stores the static variables from the previously used SystemSettings (now removed). For the syntactic sugar it wraps the getter and setters for the userSettings object to provide shorter calls across the project. Also the SettingsModel class got removed, because it served no necessary purpose (ConfigManager is the underlying model in terms of MVVM here).

Furthermore, changing the Api port restarts the whole WebApi , because it simply has to. On changing the timeout, only the SessionWatchdog timeout loop gets restarted respectively!

The logs now also get written into the workspace using the user.dir system property. Due to the assumption that the workspace will always be created right next to the directory VISAB is opened from, this works just fine - manually setting a property is more difficult than I thought, but lets forget about it, current state works fine.

Please let me know if something now has inconsistencies which I oversaw somehow!

leRoe93 commented 3 years ago

Will let this open for review until today evening around 9/10 pm so that everyone has a chance to have a look in it. After that I will merge it no matter the review ratio :)

mfroeh commented 3 years ago

I really like the new design, but i have one question. Why is the hostName displayed in the settings view? I removed it completely in #52 , now it is again in the SettingsView.fxml, but only there so i guess there went something wrong at merging?

Thats really odd.. I feel like I encountered stuff I had changed aswell, but dont know where to pinpoint it.

leRoe93 commented 3 years ago

like the new design, but i have one question. Why is the hostName displayed in the settings view? I removed it completely in #52 , now it is again in the SettingsView.fxml, but only there so i guess there went something wrong at merging?

Thats really odd.. I feel like I encountered stuff I had changed aswell, but dont know where to pinpoint it.

Very strange indeed, but as long nothing very severe got broken we should be able to live with it.

Merging now as already announced.