F cbrshooter meta view - Githubissues

VISAB-ORG / VISAB

VISAB is a standalone utility to visualize artificial intelligence agent behavior in games.

1 stars 0 forks source link

F cbrshooter meta view #78

Closed mfroeh closed 3 years ago

mfroeh commented 3 years ago

Adds

Meta View for CBRShooter
Update selected graph values
Quicker file loading (Graph values and statistics are now generated once upon loading file).

Fixes

Concurrent modification exception in CBRShooterImplicator

Refactors

IStatisticsViewModel => IVisualizeViewModel
StatisticsViewModelBase => VisualizeViewModelBase

mfroeh commented 3 years ago

tmep

mfroeh commented 3 years ago

Just merge it asap, doesn't change anything dramatically overall just improvements.

mfroeh commented 3 years ago

@TimKuno We are only using methods from CBRSHooterImplicator inside of comparison rows and that won't change any time soon. What do you think about simply moving all the logic to the respective rows? We could then also make quite the performance gains if necessary. E.g. storing results until now inside the respective row object.

TimKuno commented 3 years ago

i´m not sure if i understand what you mean, but i have solved the problems for now. I just have to test if my workaround is acceptable for larger files.

mfroeh commented 3 years ago

i´m not sure if i understand what you mean, but i have solved the problems for now. I just have to test if my workaround is acceptable for larger files.

I'm not really concerned with the performance, more so where we put the code. Right now we have a huge central module in the CBRShooterImplicator, whose methods could just be integrated directly into the ComparisonRows. It nearly never broke already on my branch after I fixed the concurrent modification and intial file loading and with your fix its now guaranteed to be stable.